netdev - Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201219095917.67401234@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 19 Dec 2020 09:59:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     <stefanc@...vell.com>
Cc:     <netdev@...r.kernel.org>, <thomas.petazzoni@...tlin.com>,
        <davem@...emloft.net>, <nadavh@...vell.com>,
        <ymarkman@...vell.com>, <linux-kernel@...r.kernel.org>,
        <linux@...linux.org.uk>, <mw@...ihalf.com>, <andrew@...n.ch>,
        <rmk+kernel@...linux.org.uk>, <stable@...r.kernel.org>
Subject: Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex
 Control configurations

On Thu, 17 Dec 2020 14:37:28 +0200 stefanc@...vell.com wrote:
> From: Stefan Chulski <stefanc@...vell.com>
> 
> During GoP port 2 Networking Complex Control mode of operation configurations,
> also GoP port 3 mode of operation was wrongly set.
> Patch removes these configurations.
> GENCONF_CTRL0_PORTX naming also fixed.

Testing the stable backport it looks like this addition change will be
problematic. Not to mention it goes against the "fixes should be
minimal" rule.

Could you please send just a one liner which removes the offending
ORing in of the bad bit?

We can do the rename soon after in net-next, the trees are merged
pretty much every week so it won't be a long wait.

> Cc: stable@...r.kernel.org
> Fixes: f84bf386f395 ("net: mvpp2: initialize the GoP")
> Signed-off-by: Stefan Chulski <stefanc@...vell.com>