netdev - Re: [RFC PATCH v2 4/8] net: sparx5: add port module support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201222150838.GN3107610@lunn.ch>
Date:   Tue, 22 Dec 2020 16:08:38 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Bjarni Jonasson <bjarni.jonasson@...rochip.com>
Cc:     Steen Hegelund <steen.hegelund@...rochip.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Madalin Bucur <madalin.bucur@....nxp.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Mark Einon <mark.einon@...il.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH v2 4/8] net: sparx5: add port module support

> > > +static int sparx5_port_verify_speed(struct sparx5 *sparx5,
> > > +                                 struct sparx5_port *port,
> > > +                                 struct sparx5_port_config *conf)
> > > +{
> > > +     case PHY_INTERFACE_MODE_SGMII:
> > > +             if (conf->speed != SPEED_1000 &&
> > > +                 conf->speed != SPEED_100 &&
> > > +                 conf->speed != SPEED_10 &&
> > > +                 conf->speed != SPEED_2500)
> > > +                     return sparx5_port_error(port, conf,
> > > SPX5_PERR_SPEED);
> > 
> > Is it really SGMII over clocked at 2500? Or 2500BaseX?
> 
> Yes the SGMII mode in the serdes driver is overclocked.
> Nothing in the switch driver needs changing when changing between
> speeds 1G/2G5.

So it continues to use the SGMII inband signalling?

There is a lot of confusion in this area, but SGMII inband signalling
overclocked does not make much sense. So it is more likely to be using
2500BaseX.

	Andrew