netdev - Re: [PATCH v3 18/24] wfx: add data_tx.c/data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874kkd97sl.fsf@codeaurora.org>
Date:   Tue, 22 Dec 2020 17:31:22 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        linux-mmc@...r.kernel.org,
        Pali Rohár <pali@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3 18/24] wfx: add data_tx.c/data_tx.h

Jerome Pouiller <Jerome.Pouiller@...abs.com> writes:

> +void wfx_tx(struct ieee80211_hw *hw, struct ieee80211_tx_control *control,
> +	    struct sk_buff *skb)
> +{
> +	struct wfx_dev *wdev = hw->priv;
> +	struct wfx_vif *wvif;
> +	struct ieee80211_sta *sta = control ? control->sta : NULL;
> +	struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb);
> +	struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data;
> +	size_t driver_data_room = sizeof_field(struct ieee80211_tx_info,
> +					       rate_driver_data);
> +
> +	compiletime_assert(sizeof(struct wfx_tx_priv) <= driver_data_room,
> +			   "struct tx_priv is too large");

Interesting, never seen compiletime_assert() before. But I suspect
BUILD_BUG_ON_MSG() is preferred, at least there are more users.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches