netdev - Re: [PATCH net] net: ipa: fix interconnect enable bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9601b599-3edb-8fff-5b22-904cca62fbda@linaro.org>
Date:   Tue, 22 Dec 2020 18:18:31 +0200
From:   Georgi Djakov <georgi.djakov@...aro.org>
To:     Alex Elder <elder@...aro.org>, davem@...emloft.net, kuba@...nel.org
Cc:     evgreen@...omium.org, cpratapa@...eaurora.org,
        bjorn.andersson@...aro.org, subashab@...eaurora.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ipa: fix interconnect enable bug

On 12/22/20 17:16, Alex Elder wrote:
> When the core clock rate and interconnect bandwidth specifications
> were moved into configuration data, a copy/paste bug was introduced,
> causing the memory interconnect bandwidth to be set three times
> rather than enabling the three different interconnects.
> 
> Fix this bug.
> 
> Fixes: 91d02f9551501 ("net: ipa: use config data for clocking")
> Signed-off-by: Alex Elder <elder@...aro.org>

Reviewed-by: Georgi Djakov <georgi.djakov@...aro.org>

> ---
>   drivers/net/ipa/ipa_clock.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
> index 9dcf16f399b7a..135c393437f12 100644
> --- a/drivers/net/ipa/ipa_clock.c
> +++ b/drivers/net/ipa/ipa_clock.c
> @@ -115,13 +115,13 @@ static int ipa_interconnect_enable(struct ipa *ipa)
>   		return ret;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_IMEM];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->imem_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_memory_path_disable;
>   
>   	data = &clock->interconnect_data[IPA_INTERCONNECT_CONFIG];
> -	ret = icc_set_bw(clock->memory_path, data->average_rate,
> +	ret = icc_set_bw(clock->config_path, data->average_rate,
>   			 data->peak_rate);
>   	if (ret)
>   		goto err_imem_path_disable;
>