netdev - [PATCH] rtw88: coex: remove useless if and else

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Dec 2020 20:28:57 +0800
From:   Tian Tao <tiantao6@...ilicon.com>
To:     <tony0620emma@...il.com>, <kvalo@...eaurora.org>,
        <davem@...emloft.net>, <kuba@...nel.org>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: [PATCH] rtw88: coex: remove useless if and else

Fix the following coccinelle report:
drivers/net/wireless/realtek/rtw88/coex.c:1619:3-5: WARNING:
possible condition with no effect (if == else)

Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
---
 drivers/net/wireless/realtek/rtw88/coex.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/coex.c b/drivers/net/wireless/realtek/rtw88/coex.c
index 24530ca..df6676a 100644
--- a/drivers/net/wireless/realtek/rtw88/coex.c
+++ b/drivers/net/wireless/realtek/rtw88/coex.c
@@ -1616,12 +1616,7 @@ static void rtw_coex_action_bt_relink(struct rtw_dev *rtwdev)
 	if (efuse->share_ant) { /* Shared-Ant */
 		if (coex_stat->wl_gl_busy) {
 			table_case = 26;
-			if (coex_stat->bt_hid_exist &&
-			    coex_stat->bt_profile_num == 1) {
-				tdma_case = 20;
-			} else {
-				tdma_case = 20;
-			}
+			tdma_case = 20;
 		} else {
 			table_case = 1;
 			tdma_case = 0;
-- 
2.7.4