lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2020 12:32:18 -0800 From: Jakub Kicinski <kuba@...nel.org> To: Andrew Lunn <andrew@...n.ch> Cc: Dinghao Liu <dinghao.liu@....edu.cn>, kjlu@....edu, "David S. Miller" <davem@...emloft.net>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe On Wed, 23 Dec 2020 16:33:04 +0100 Andrew Lunn wrote: > On Wed, Dec 23, 2020 at 07:06:12PM +0800, Dinghao Liu wrote: > > When mdiobus_register() fails, priv->mdio allocated > > by mdiobus_alloc() has not been freed, which leads > > to memleak. > > > > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn> > > Fixes: bfa49cfc5262 ("net/ethoc: fix null dereference on error exit path") > > Reviewed-by: Andrew Lunn <andrew@...n.ch> Ooof, I applied without looking at your email and I added: Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core") I believe this is the correct Fixes tag. Before the exit patch was freeing both MDIO and the IRQ depending on the fact that kfree(NULL) is fine. Am I wrong? Not that we can fix it now :)
Powered by blists - more mailing lists