lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Dec 2020 21:20:24 -0500 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: "Andrea Parri (Microsoft)" <parri.andrea@...il.com>, Saruhan Karademir <skarade@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Wei Liu <wei.liu@...nel.org>, Sasha Levin <sashal@...nel.org>, linux-hyperv@...r.kernel.org Subject: [PATCH AUTOSEL 4.19 48/87] hv_netvsc: Validate number of allocated sub-channels From: "Andrea Parri (Microsoft)" <parri.andrea@...il.com> [ Upstream commit 206ad34d52a2f1205c84d08c12fc116aad0eb407 ] Lack of validation could lead to out-of-bound reads and information leaks (cf. usage of nvdev->chan_table[]). Check that the number of allocated sub-channels fits into the expected range. Suggested-by: Saruhan Karademir <skarade@...rosoft.com> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com> Acked-by: Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net> Cc: Jakub Kicinski <kuba@...nel.org> Cc: netdev@...r.kernel.org Link: https://lore.kernel.org/r/20201118153310.112404-1-parri.andrea@gmail.com Signed-off-by: Wei Liu <wei.liu@...nel.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- drivers/net/hyperv/rndis_filter.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index dd91834f841d5..1554d4fa0bb08 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -1111,6 +1111,11 @@ int rndis_set_subchannel(struct net_device *ndev, return -EIO; } + /* Check that number of allocated sub channel is within the expected range */ + if (init_packet->msg.v5_msg.subchn_comp.num_subchannels > nvdev->num_chn - 1) { + netdev_err(ndev, "invalid number of allocated sub channel\n"); + return -EINVAL; + } nvdev->num_chn = 1 + init_packet->msg.v5_msg.subchn_comp.num_subchannels; -- 2.27.0
Powered by blists - more mailing lists