netdev - Re: [PATCH net] ibmvnic: fix login buffer memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <160869180724.29227.18193097363858256471.git-patchwork-notify@kernel.org>
Date:   Wed, 23 Dec 2020 02:50:07 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Lijun Pan <ljp@...ux.ibm.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] ibmvnic: fix login buffer memory leak

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 19 Dec 2020 15:39:19 -0600 you wrote:
> Commit 34f0f4e3f488 ("ibmvnic: Fix login buffer memory leaks") frees
> login_rsp_buffer in release_resources() and send_login()
> because handle_login_rsp() does not free it.
> Commit f3ae59c0c015 ("ibmvnic: store RX and TX subCRQ handle array in
> ibmvnic_adapter struct") frees login_rsp_buffer in handle_login_rsp().
> It seems unnecessary to free it in release_resources() and send_login().
> There are chances that handle_login_rsp returns earlier without freeing
> buffers. Double-checking the buffer is harmless since
> release_login_buffer and release_login_rsp_buffer will
> do nothing if buffer is already freed.
> 
> [...]

Here is the summary with links:
  - [net] ibmvnic: fix login buffer memory leak
    https://git.kernel.org/netdev/net/c/a0c8be56affa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html