netdev - Re: [PATCH] net/mlx5e: remove h from printk format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201224062652.GB18357@unreal>
Date:   Thu, 24 Dec 2020 08:26:52 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     trix@...hat.com
Cc:     saeedm@...dia.com, davem@...emloft.net, kuba@...nel.org,
        vladyslavt@...dia.com, maximmi@...lanox.com, tariqt@...dia.com,
        bjorn.topel@...el.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: remove h from printk format specifier

On Wed, Dec 23, 2020 at 11:45:12AM -0800, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
>
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]")
>
> Standard integer promotion is already done and %hx and %hhx is useless
> so do not encourage the use of %hh[xudi] or %h[xudi].
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_main.c   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>