netdev - RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Dec 2020 10:46:47 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Igor Russkikh <irusskikh@...vell.com>,
        "Sudarsana Reddy Kalluru" <skalluru@...vell.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: RE: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets

> -----Original Message-----
> From: Manish Chopra <manishc@...vell.com>
> Sent: Monday, December 21, 2020 8:26 PM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; Ariel Elior <aelior@...vell.com>; Igor Russkikh
> <irusskikh@...vell.com>; Sudarsana Reddy Kalluru <skalluru@...vell.com>
> Subject: [PATCH net 1/1] qede: fix offload for IPIP tunnel packets
> 
> IPIP tunnels packets are unknown to device, hence these packets are
> incorrectly parsed and caused the packet corruption, so disable offlods for
> such packets at run time.
> 
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> Signed-off-by: Sudarsana Kalluru <skalluru@...vell.com>
> Signed-off-by: Igor Russkikh <irusskikh@...vell.com>
> ---
>  drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> index a2494bf..ca0ee29 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
> @@ -1799,6 +1799,11 @@ netdev_features_t qede_features_check(struct
> sk_buff *skb,
>  			      ntohs(udp_hdr(skb)->dest) != gnv_port))
>  				return features & ~(NETIF_F_CSUM_MASK |
>  						    NETIF_F_GSO_MASK);
> +		} else if (l4_proto == IPPROTO_IPIP) {
> +			/* IPIP tunnels are unknown to the device or at least
> unsupported natively,
> +			 * offloads for them can't be done trivially, so disable
> them for such skb.
> +			 */
> +			return features & ~(NETIF_F_CSUM_MASK |
> NETIF_F_GSO_MASK);
>  		}
>  	}
> 
> --
> 1.8.3.1

Hello Jakub,  can you please queue up for stable releases (specifically for long term linux 5.4)?

Thanks,
Manish