lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 24 Dec 2020 10:56:16 -0500
From:   Willem de Bruijn <>
To:     wangyunjian <>
Cc:     Network Development <>,
        "Michael S. Tsirkin" <>,
        Jason Wang <>,
        Willem de Bruijn <>,,
        "Lilijun (Jerry)" <>,
        chenchanghu <>,
        xudingke <>,
        "huangbin (J)" <>
Subject: Re: [PATCH net] tun: fix return value when the number of iovs exceeds MAX_SKB_FRAGS

On Thu, Dec 24, 2020 at 6:51 AM wangyunjian <> wrote:
> From: Yunjian Wang <>
> Currently the tun_napi_alloc_frags() function returns -ENOMEM when the
> number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate,
> we should use -EMSGSIZE instead of -ENOMEM.
> Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
> Signed-off-by: Yunjian Wang <>

Acked-by: Willem de Bruijn <>

It might be good to explain why the distinction matters: one denotes a
transient failure that the caller (specifically vhost_net) can retry,
the other a persistent failure due to bad packet geometry that should
be dropped.

Powered by blists - more mailing lists