netdev - Re: [PATCH] net: phy: realtek: Add support for RTL9000AA/AN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201225013427.GV3107610@lunn.ch>
Date:   Fri, 25 Dec 2020 02:34:27 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuusuke Ashizuka <ashiduka@...itsu.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, torii.ken1@...itsu.com
Subject: Re: [PATCH] net: phy: realtek: Add support for RTL9000AA/AN

> +static int rtl9000a_ack_interrupt(struct phy_device *phydev)
> +{
> +	int err;
> +
> +	err = phy_read(phydev, RTL8211F_INSR);
> +
> +	return (err < 0) ? err : 0;
> +}
> +
> +static int rtl9000a_config_intr(struct phy_device *phydev)
> +{
> +	u16 val;
> +
> +	if (phydev->interrupts == PHY_INTERRUPT_ENABLED)
> +		val = (u16)~RTL9000A_GINMR_LINK_STATUS;
> +	else
> +		val = ~0;
> +
> +	return phy_write_paged(phydev, 0xa42, RTL9000A_GINMR, val);
> +}

You need to rework this for the recent change to interrupt handling.

    Andrew