netdev - Re: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c4587112-cd05-aeec-3307-8fd813060dd8@redhat.com>
Date:   Fri, 25 Dec 2020 14:15:10 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     wangyunjian <wangyunjian@...wei.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mst@...hat.com" <mst@...hat.com>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        "Lilijun (Jerry)" <jerry.lilijun@...wei.com>,
        chenchanghu <chenchanghu@...wei.com>,
        xudingke <xudingke@...wei.com>,
        "huangbin (J)" <brian.huangbin@...wei.com>
Subject: Re: [PATCH net v4 2/2] vhost_net: fix tx queue stuck when sendmsg
 fails


On 2020/12/24 下午5:09, wangyunjian wrote:
>> -EAGAIN and -ENOBFS are fine. But I don't see how -ENOMEM can be returned.
> The tun_build_skb() and tun_napi_alloc_frags() return -ENOMEM when memory
> allocation fails.
>
> Thanks
>

You're right. So I think we need check them all.

In the future, we need think of a better way. I feel such check is kind 
of fragile since people may modify core sock codes without having a look 
at what vhost does.

Thanks