netdev - Re: [PATCH net] net: hns: fix return value check in __lb_other

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b056799-b330-cff1-963c-24ca138817a2@huawei.com>
Date:   Sat, 26 Dec 2020 14:38:43 +0800
From:   Yonglong Liu <liuyonglong@...wei.com>
To:     wangyunjian <wangyunjian@...wei.com>, <netdev@...r.kernel.org>
CC:     <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <jerry.lilijun@...wei.com>, <xudingke@...wei.com>
Subject: Re: [PATCH net] net: hns: fix return value check in
 __lb_other_process()


On 2020/12/25 18:35, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
>
> The function skb_copy() could return NULL, the return value
> need to be checked.
>
> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> ---
>   drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
> index 7165da0ee9aa..ad18f0e20a23 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
> @@ -415,6 +415,10 @@ static void __lb_other_process(struct hns_nic_ring_data *ring_data,
>   	/* for mutl buffer*/
>   	new_skb = skb_copy(skb, GFP_ATOMIC);
>   	dev_kfree_skb_any(skb);
> +	if (!new_skb) {

> +		ndev->stats.rx_dropped++;
You can add a new drop type to ring->states, and then add it to 
ndev->stats.rx_dropped,

then you can know that the rx_dropped is from skb_copy() failed.

This process is from self-test, maybe you can just add a error message 
rather than increase

the ndev->stats.rx_dropped.


> +		return;
> +	}
>   	skb = new_skb;
>   
>   	check_ok = 0;