lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 27 Dec 2020 14:30:37 +0100
From:   Linus Walleij <>
To:     Vladimir Oltean <>
Cc:     "David S. Miller" <>,
        Jakub Kicinski <>,
        netdev <>,
        Florian Fainelli <>,
        Andrew Lunn <>,
        Vivien Didelot <>,
        Vladimir Oltean <>,
        Kurt Kanzenbach <>,
        Hauke Mehrtens <>,
        Woojung Huh <>,
        Microchip Linux Driver Support <>,
        Sean Wang <>,
        Landen Chao <>,
        Claudiu Manoil <>,
        Alexandre Belloni <>,
        Vadym Kochan <>,
        Taras Chornyi <>,
        Jiri Pirko <>, Ido Schimmel <>,
        Grygorii Strashko <>,
        Ioana Ciornei <>,
        Ivan Vecera <>
Subject: Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic
 from VLAN objects

On Thu, Dec 17, 2020 at 2:59 AM Vladimir Oltean <> wrote:

> It should be the driver's business to logically separate its VLAN
> offloading into a preparation and a commit phase, and some drivers don't
> need / can't do this.
> So remove the transactional shim from DSA and let drivers to propagate
> errors directly from the .port_vlan_add callback.
> Signed-off-by: Vladimir Oltean <>

This makes the RTL8366 handle errors in a strict way so:
Reviewed-by: Linus Wallei <>

Linus Walleij

Powered by blists - more mailing lists