lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Dec 2020 14:00:33 +0100 From: Michael Walle <michael@...le.cc> To: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Cc: Claudiu Manoil <claudiu.manoil@....com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Alex Marginean <alexandru.marginean@....com>, Vladimir Oltean <vladimir.oltean@....com>, Michael Walle <michael@...le.cc>, Andrew Lunn <andrew@...n.ch> Subject: [PATCH RESEND net-next 3/4] enetc: drop MDIO_DATA() macro value is u16, masking with 0xffff is a nop. Drop it. Signed-off-by: Michael Walle <michael@...le.cc> Reviewed-by: Andrew Lunn <andrew@...n.ch> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com> Tested-by: Vladimir Oltean <vladimir.oltean@....com> --- drivers/net/ethernet/freescale/enetc/enetc_mdio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c index 665f7a0c71cb..591b16f01507 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc_mdio.c +++ b/drivers/net/ethernet/freescale/enetc/enetc_mdio.c @@ -41,7 +41,6 @@ static inline void enetc_mdio_wr(struct enetc_mdio_priv *mdio_priv, int off, #define MDIO_CTL_DEV_ADDR(x) ((x) & 0x1f) #define MDIO_CTL_PORT_ADDR(x) (((x) & 0x1f) << 5) #define MDIO_CTL_READ BIT(15) -#define MDIO_DATA(x) ((x) & 0xffff) static bool enetc_mdio_is_busy(struct enetc_mdio_priv *mdio_priv) { @@ -93,7 +92,7 @@ int enetc_mdio_write(struct mii_bus *bus, int phy_id, int regnum, u16 value) } /* write the value */ - enetc_mdio_wr(mdio_priv, ENETC_MDIO_DATA, MDIO_DATA(value)); + enetc_mdio_wr(mdio_priv, ENETC_MDIO_DATA, value); ret = enetc_mdio_wait_complete(mdio_priv); if (ret) -- 2.20.1
Powered by blists - more mailing lists