netdev - Re: [PATCH net 2/2] bareudp: Fix use of incorrect min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMArcTVQmwrbeT=LNsNhSP4Cykz-ZchbpS4RQJpo=J_F8Pv-aQ@mail.gmail.com>
Date:   Mon, 28 Dec 2020 11:26:44 +0900
From:   Taehee Yoo <ap420073@...il.com>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Netdev <netdev@...r.kernel.org>, martin.varghese@...ia.com
Subject: Re: [PATCH net 2/2] bareudp: Fix use of incorrect min_headroom size

On Mon, 28 Dec 2020 at 01:33, Guillaume Nault <gnault@...hat.com> wrote:
>

Hi Guillaume,
Thank you for the review!

> On Sat, Dec 26, 2020 at 05:13:08PM +0000, Taehee Yoo wrote:
> > In the bareudp6_xmit_skb(), it calculates min_headroom.
> > At that point, it uses struct iphdr, but it's not correct.
> > So panic could occur.
> > The struct ipv6hdr should be used.
> >
> > Test commands:
> >     ip netns add A
> >     ip netns add B
> >     ip link add veth0 type veth peer name veth1
> >     ip link set veth0 netns A
>
> Missing "ip link set veth1 netns B", so the reproducer unfortunately
> doesn't work.
>

Sorry, This is my mistake.

> BTW, you can also simplify the script by creating the veth devices
> directly in the right netns:
>   ip link add name veth0 netns A type veth peer name veth1 netns B
>

Thanks, It's really useful to me :)

> Apart from that,
> Acked-by: Guillaume Nault <gnault@...hat.com>
>
> And thanks a lot for the reproducers!

Thank you so much for the review,
I will send a v2 patch, which will fix a reproducer script.