netdev - Re: [PATCH -net] net: sched: prevent invalid Scell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201228.145401.2067471886598959966.davem@davemloft.net>
Date:   Mon, 28 Dec 2020 14:54:01 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     linux-kernel@...r.kernel.org,
        syzbot+97c5bd9cc81eca63d36e@...kaller.appspotmail.com,
        nogahf@...lanox.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, netdev@...r.kernel.org, kuba@...nel.org
Subject: Re: [PATCH -net] net: sched: prevent invalid Scell_log shift count

From: Randy Dunlap <rdunlap@...radead.org>
Date: Thu, 24 Dec 2020 22:23:44 -0800

> Check Scell_log shift size in red_check_params() and modify all callers
> of red_check_params() to pass Scell_log.
> 
> This prevents a shift out-of-bounds as detected by UBSAN:
>   UBSAN: shift-out-of-bounds in ./include/net/red.h:252:22
>   shift exponent 72 is too large for 32-bit type 'int'
> 
> Fixes: 8afa10cbe281 ("net_sched: red: Avoid illegal values")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: syzbot+97c5bd9cc81eca63d36e@...kaller.appspotmail.com

Applied and queued up for -stable, thanks.