netdev - Re: [Patch net] erspan: fix version 1 check in gre_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201228.150103.7398661656696572.davem@davemloft.net>
Date:   Mon, 28 Dec 2020 15:01:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, cong.wang@...edance.com,
        syzbot+f583ce3d4ddf9836b27a@...kaller.appspotmail.com,
        u9012063@...il.com, lorenzo.bianconi@...hat.com
Subject: Re: [Patch net] erspan: fix version 1 check in gre_parse_header()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Sat, 26 Dec 2020 15:44:53 -0800

> From: Cong Wang <cong.wang@...edance.com>
> 
> Both version 0 and version 1 use ETH_P_ERSPAN, but version 0 does not
> have an erspan header. So the check in gre_parse_header() is wrong,
> we have to distinguish version 1 from version 0.
> 
> We can just check the gre header length like is_erspan_type1().
> 
> Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup")
> Reported-by: syzbot+f583ce3d4ddf9836b27a@...kaller.appspotmail.com
> Cc: William Tu <u9012063@...il.com>
> Cc: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> Signed-off-by: Cong Wang <cong.wang@...edance.com>

Applied and queued up for -stable, thanks.