[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201228134309.1126941c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Mon, 28 Dec 2020 13:43:09 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: wangyunjian <wangyunjian@...wei.com>, <mst@...hat.com>,
<jasowang@...hat.com>, <willemdebruijn.kernel@...il.com>
Cc: <netdev@...r.kernel.org>,
<virtualization@...ts.linux-foundation.org>,
<jerry.lilijun@...wei.com>, <chenchanghu@...wei.com>,
<xudingke@...wei.com>, <brian.huangbin@...wei.com>
Subject: Re: [PATCH net v2] tun: fix return value when the number of iovs
exceeds MAX_SKB_FRAGS
On Fri, 25 Dec 2020 10:52:16 +0800 wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@...wei.com>
>
> Currently the tun_napi_alloc_frags() function returns -ENOMEM when the
> number of iovs exceeds MAX_SKB_FRAGS + 1. However this is inappropriate,
> we should use -EMSGSIZE instead of -ENOMEM.
>
> The following distinctions are matters:
> 1. the caller need to drop the bad packet when -EMSGSIZE is returned,
> which means meeting a persistent failure.
> 2. the caller can try again when -ENOMEM is returned, which means
> meeting a transient failure.
>
> Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
> Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> Acked-by: Willem de Bruijn <willemb@...gle.com>
Applied, thanks everyone!
Powered by blists - more mailing lists