netdev - Re: [PATCH] CDC-NCM: remove "connected" log message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201228133036.3a2e9fb5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 28 Dec 2020 13:30:36 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Roland Dreier <roland@...nel.org>
Cc:     Oliver Neukum <oliver@...kum.org>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH] CDC-NCM: remove "connected" log message

On Thu, 24 Dec 2020 08:53:52 +0100 Greg KH wrote:
> On Wed, Dec 23, 2020 at 07:21:16PM -0800, Roland Dreier wrote:
> > The cdc_ncm driver passes network connection notifications up to
> > usbnet_link_change(), which is the right place for any logging.
> > Remove the netdev_info() duplicating this from the driver itself.
> > 
> > This stops devices such as my "TRENDnet USB 10/100/1G/2.5G LAN"
> > (ID 20f4:e02b) adapter from spamming the kernel log with
> > 
> >     cdc_ncm 2-2:2.0 enp0s2u2c2: network connection: connected
> > 
> > messages every 60 msec or so.
> > 
> > Signed-off-by: Roland Dreier <roland@...nel.org>
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Applied to net and queued for LTS, thanks!