netdev - Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201228132143.39edf28d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 28 Dec 2020 13:21:43 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Bongsu Jeon <bongsu.jeon2@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-nfc@...ts.01.org,
        Bongsu Jeon <bongsu.jeon@...sung.com>
Subject: Re: [PATCH net-next] net: nfc: nci: Change the NCI close sequence

On Mon, 28 Dec 2020 10:46:31 +0900 Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@...sung.com>
> 
> Change the NCI close sequence because the NCI Command timer should be
> deleted after flushing the NCI command work queue.

The commit message should describe the reason - why new order is
better than the old one. The existing sentence describes what is
changing more than why.