netdev - RE: [PATCH v5 bpf-next 1/2] net: xdp: introduce xdp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5feac0f6a2a6c_7421e20843@john-XPS-13-9370.notmuch>
Date:   Mon, 28 Dec 2020 21:39:02 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, ast@...nel.org,
        daniel@...earbox.net, brouer@...hat.com,
        lorenzo.bianconi@...hat.com, alexander.duyck@...il.com,
        maciej.fijalkowski@...el.com, saeed@...nel.org
Subject: RE: [PATCH v5 bpf-next 1/2] net: xdp: introduce xdp_init_buff utility
 routine

Lorenzo Bianconi wrote:
> Introduce xdp_init_buff utility routine to initialize xdp_buff fields
> const over NAPI iterations (e.g. frame_sz or rxq pointer). Rely on
> xdp_init_buff in all XDP capable drivers.
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---

Seems like a nice bit of cleanup. I spot checked math in a few drivers LGTM.

Acked-by: John Fastabend <john.fastabend@...il.com>