[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bc85dfe9-7689-2be1-b124-0f0529e1d8dc@redhat.com>
Date: Wed, 30 Dec 2020 14:33:53 +0800
From: Jason Wang <jasowang@...hat.com>
To: Eli Cohen <elic@...dia.com>
Cc: mst@...hat.com, eperezma@...hat.com, kvm@...r.kernel.org,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, lulu@...hat.com, eli@...lanox.com,
lingshan.zhu@...el.com, rob.miller@...adcom.com,
stefanha@...hat.com, sgarzare@...hat.com
Subject: Re: [PATCH 11/21] vhost-vdpa: introduce asid based IOTLB
On 2020/12/29 下午8:05, Eli Cohen wrote:
>> +
>> +static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid)
> The return value is never interpreted. I think it should either be made
> void or return values checked.
Right, will make it void.
>
>> +{
>> + struct vhost_vdpa_as *as = asid_to_as(v, asid);
>> +
>> + /* Remove default address space is not allowed */
>> + if (asid == 0)
>> + return -EINVAL;
> Can you explain why? I think you have a memory leak due to this as no
> one will ever free as with id 0.
>
Looks like a bug. Will remove this.
Thanks
Powered by blists - more mailing lists