netdev - Re: [PATCH iproute2-next 7/9] dcb: Support -n to suppress translation to nice names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 01 Jan 2021 22:34:35 +0100
From:   Petr Machata <me@...chata.org>
To:     David Ahern <dsahern@...il.com>
Cc:     Petr Machata <me@...chata.org>, netdev@...r.kernel.org,
        stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next 7/9] dcb: Support -n to suppress
 translation to nice names


David Ahern <dsahern@...il.com> writes:

> On 12/23/20 11:25 AM, Petr Machata wrote:
>> diff --git a/dcb/dcb.c b/dcb/dcb.c
>> index a59b63ac9159..e6cda7337924 100644
>> --- a/dcb/dcb.c
>> +++ b/dcb/dcb.c
>> @@ -467,7 +467,8 @@ static void dcb_help(void)
>>  		"       dcb [ -f | --force ] { -b | --batch } filename [ -N | --Netns ] netnsname\n"
>>  		"where  OBJECT := { buffer | ets | maxrate | pfc }\n"
>>  		"       OPTIONS := [ -V | --Version | -i | --iec | -j | --json\n"
>> -		"                  | -p | --pretty | -s | --statistics | -v | --verbose]\n");
>> +		"                  | -n | --no-nice-names | -p | --pretty\n"
>
>
> iproute2 commands really should have a consistent user interface.
> Unfortunately -N and -n are inconsistent with the newer commands like
> devlink. dcb has not been released yet so time to fix this.
>
> devlink is the only one using the horribly named 'no-nice-names', and we
> should avoid propagating that to dcb. At a minimum it should be
> 'numeric' which is consistent with the others.
>
> My preference is also to have dcb follow ip and tc (vs ss) with '-n' to
> mean -netns and -N' to mean numeric.

Agreed on all counts.