lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Jan 2021 15:49:54 -0800 From: Cong Wang <xiyou.wangcong@...il.com> To: Jakub Kicinski <kuba@...nel.org> Cc: David Miller <davem@...emloft.net>, Linux Kernel Network Developers <netdev@...r.kernel.org>, martin.varghese@...ia.com, Willem de Bruijn <willemb@...gle.com> Subject: Re: [PATCH net] net: bareudp: add missing error handling for bareudp_link_config() On Wed, Dec 30, 2020 at 7:46 PM Jakub Kicinski <kuba@...nel.org> wrote: > @@ -661,9 +662,14 @@ static int bareudp_newlink(struct net *net, struct net_device *dev, > > err = bareudp_link_config(dev, tb); > if (err) > - return err; > + goto err_unconfig; > > return 0; > + > +err_unconfig: I think we can save this goto. > + list_del(&bareudp->next); > + unregister_netdevice(dev); Which is bareudp_dellink(dev, NULL). ;) Thanks.
Powered by blists - more mailing lists