netdev - Re: [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4139341d-86b7-db39-6586-d61fd41d8be7@denx.de>
Date:   Sun, 3 Jan 2021 13:58:09 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH 2/2] net: ks8851: Register MDIO bus and the internal PHY

On 12/30/20 5:00 PM, Andrew Lunn wrote:
>> +static int ks8851_mdio_read(struct mii_bus *bus, int phy_id, int reg)
>> +{
>> +	struct ks8851_net *ks = bus->priv;
>> +
>> +	if (phy_id != 0)
>> +		return 0xffffffff;
>> +
> 
> Please check for C45 and return -EOPNOTSUPP.

The ks8851_reg_read() does all the register checking already.