lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jan 2021 02:35:50 +0100 From: Hauke Mehrtens <hauke@...ke-m.de> To: Martin Blumenstingl <martin.blumenstingl@...glemail.com>, netdev@...r.kernel.org Cc: andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com, davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs On 1/3/21 2:25 AM, Martin Blumenstingl wrote: > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > Without this the PHY link is detected properly and ethtool statistics > for TX are increasing but there's no RX traffic coming in. > > Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") > Cc: stable@...r.kernel.org > Suggested-by: Hauke Mehrtens <hauke@...ke-m.de> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> Acked-by: Hauke Mehrtens <hauke@...ke-m.de> > --- > drivers/net/dsa/lantiq_gswip.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c > index 09701c17f3f6..5d378c8026f0 100644 > --- a/drivers/net/dsa/lantiq_gswip.c > +++ b/drivers/net/dsa/lantiq_gswip.c > @@ -1541,9 +1541,7 @@ static void gswip_phylink_mac_link_up(struct dsa_switch *ds, int port, > { > struct gswip_priv *priv = ds->priv; > > - /* Enable the xMII interface only for the external PHY */ > - if (interface != PHY_INTERFACE_MODE_INTERNAL) > - gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port); > + gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port); > } > > static void gswip_get_strings(struct dsa_switch *ds, int port, u32 stringset, >
Powered by blists - more mailing lists