netdev - Re: [PATCH 1/5] vsock/virtio: support for SOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 Jan 2021 06:04:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Arseny Krasnov <arseny.krasnov@...persky.com>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Stefano Garzarella <sgarzare@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jorgen Hansen <jhansen@...are.com>,
        Colin Ian King <colin.king@...onical.com>,
        Arseniy Krasnov <oxffffaa@...il.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

Hi Arseny,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc1 next-20201223]
[cannot apply to vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Arseny-Krasnov/virtio-vsock-introduce-SOCK_SEQPACKET-support/20210104-041042
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3516bd729358a2a9b090c1905bd2a3fa926e24c6
config: ia64-randconfig-s031-20210104 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-184-g1b896707-dirty
        # https://github.com/0day-ci/linux/commit/0fa3b3d10df0564a37d3ddf00d954a2bfaec8718
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Arseny-Krasnov/virtio-vsock-introduce-SOCK_SEQPACKET-support/20210104-041042
        git checkout 0fa3b3d10df0564a37d3ddf00d954a2bfaec8718
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


"sparse warnings: (new ones prefixed by >>)"
   net/vmw_vsock/virtio_transport_common.c:162:13: sparse: sparse: cast to restricted __le32
>> net/vmw_vsock/virtio_transport_common.c:162:13: sparse: sparse: cast from restricted __le16
>> net/vmw_vsock/virtio_transport_common.c:560:29: sparse: sparse: cast to restricted __le16
>> net/vmw_vsock/virtio_transport_common.c:560:29: sparse: sparse: cast from restricted __le32
   net/vmw_vsock/virtio_transport_common.c:1106:17: sparse: sparse: cast to restricted __le32
   net/vmw_vsock/virtio_transport_common.c:1106:17: sparse: sparse: cast from restricted __le16

vim +162 net/vmw_vsock/virtio_transport_common.c

   158	
   159	void virtio_transport_deliver_tap_pkt(struct virtio_vsock_pkt *pkt)
   160	{
   161		/* TODO: implement tap support for SOCK_SEQPACKET. */
 > 162		if (le32_to_cpu(pkt->hdr.type) == VIRTIO_VSOCK_TYPE_SEQPACKET)
   163			return;
   164	
   165		if (pkt->tap_delivered)
   166			return;
   167	
   168		vsock_deliver_tap(virtio_transport_build_skb, pkt);
   169		pkt->tap_delivered = true;
   170	}
   171	EXPORT_SYMBOL_GPL(virtio_transport_deliver_tap_pkt);
   172	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35097 bytes)