netdev - Re: [PATCH net] smc: fix out of bound access in smc_nl_get_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4ca9487e-2834-1c45-68eb-a6be8be671d3@linux.ibm.com>
Date:   Mon, 4 Jan 2021 12:53:49 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     guvenc@...ux.ibm.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org,
        syzbot+f4708c391121cfc58396@...kaller.appspotmail.com
Subject: Re: [PATCH net] smc: fix out of bound access in smc_nl_get_sys_info()

Thank you Jakub,

this patch solves the out of bounds access due to snprintf() copying size bytes first
and overwriting the last byte with null afterwards.
We will include your patch in our next series for the net tree soon.

Reviewed-by: Karsten Graul <kgraul@...ux.ibm.com>

On 30/12/2020 01:48, Jakub Kicinski wrote:
> smc_clc_get_hostname() sets the host pointer to a buffer
> which is not NULL-terminated (see smc_clc_init()).
> 
> Reported-by: syzbot+f4708c391121cfc58396@...kaller.appspotmail.com
> Fixes: 099b990bd11a ("net/smc: Add support for obtaining system information")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  net/smc/smc_core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c
> index 59342b519e34..8d866b4ed8f6 100644
> --- a/net/smc/smc_core.c
> +++ b/net/smc/smc_core.c
> @@ -246,7 +246,8 @@ int smc_nl_get_sys_info(struct sk_buff *skb, struct netlink_callback *cb)
>  		goto errattr;
>  	smc_clc_get_hostname(&host);
>  	if (host) {
> -		snprintf(hostname, sizeof(hostname), "%s", host);
> +		memcpy(hostname, host, SMC_MAX_HOSTNAME_LEN);
> +		hostname[SMC_MAX_HOSTNAME_LEN] = 0;
>  		if (nla_put_string(skb, SMC_NLA_SYS_LOCAL_HOST, hostname))
>  			goto errattr;
>  	}
> 

-- 
Karsten

(I'm a dude)