netdev - Re: [PATCH net v2 0/2] bareudp: fix several issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210104131442.0ca9bf83@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 4 Jan 2021 13:14:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Taehee Yoo <ap420073@...il.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gnault@...hat.com
Subject: Re: [PATCH net v2 0/2] bareudp: fix several issues

On Mon, 28 Dec 2020 15:21:21 +0000 Taehee Yoo wrote:
> This patchset is to fix problems when bareudp is used nestedly.
> 
> 1. If the NETIF_F_LLTX flag is not set, the lockdep warns about
> a possible deadlock scenario when bareudp interfaces are used nestedly.
> But, like other tunneling interfaces, bareudp doesn't need xmit lock.
> So, it sets NETIF_F_LLTTX.
> Lockdep no more warns about a possible deadlock scenario.
> 
> 2. bareudp interface calculates min_headroom when it sends a packet.
> When it calculates min_headroom, it uses the size of struct iphdr even
> the ipv6 packet is going to be sent.
> It would result in a lack of headroom so eventually occurs kernel panic.

Applied, thanks!