netdev - Re: [PATCH v3] Drivers: hv: vmbus: Copy packets sent by Hyper-V out of the ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Jan 2021 12:45:30 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Michael Kelley <mikelley@...rosoft.com>
Cc:     "Andrea Parri (Microsoft)" <parri.andrea@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        Juan Vazquez <juvazq@...rosoft.com>,
        Saruhan Karademir <skarade@...rosoft.com>,
        Andres Beltran <lkmlabelt@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v3] Drivers: hv: vmbus: Copy packets sent by Hyper-V out
 of the ring buffer

On Tue, Dec 22, 2020 at 01:59:34PM +0000, Michael Kelley wrote:
> From: Andrea Parri (Microsoft) <parri.andrea@...il.com> Sent: Monday, December 7, 2020 8:53 PM
> > 
> > From: Andres Beltran <lkmlabelt@...il.com>
> > 
> > Pointers to ring-buffer packets sent by Hyper-V are used within the
> > guest VM. Hyper-V can send packets with erroneous values or modify
> > packet fields after they are processed by the guest. To defend
> > against these scenarios, return a copy of the incoming VMBus packet
> > after validating its length and offset fields in hv_pkt_iter_first().
> > In this way, the packet can no longer be modified by the host.
> > 
> > Signed-off-by: Andres Beltran <lkmlabelt@...il.com>
> > Co-developed-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Jakub Kicinski <kuba@...nel.org>
> > Cc: "James E.J. Bottomley" <jejb@...ux.ibm.com>
> > Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> > Cc: netdev@...r.kernel.org
> > Cc: linux-scsi@...r.kernel.org
> > ---
> >  drivers/hv/channel.c              |  9 ++--
> >  drivers/hv/hv_fcopy.c             |  1 +
> >  drivers/hv/hv_kvp.c               |  1 +
> >  drivers/hv/hyperv_vmbus.h         |  2 +-
> >  drivers/hv/ring_buffer.c          | 82 ++++++++++++++++++++++++++-----
> >  drivers/net/hyperv/hyperv_net.h   |  3 ++
> >  drivers/net/hyperv/netvsc.c       |  2 +
> >  drivers/net/hyperv/rndis_filter.c |  2 +
> >  drivers/scsi/storvsc_drv.c        | 10 ++++
> >  include/linux/hyperv.h            | 48 +++++++++++++++---
> >  net/vmw_vsock/hyperv_transport.c  |  4 +-
> >  11 files changed, 139 insertions(+), 25 deletions(-)
> > 
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Applied to hyperv-next.