netdev - Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f5be5508fd3110e01823d03b3188f5ceef3a5d1.camel@kernel.org>
Date:   Tue, 05 Jan 2021 13:04:10 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>,
        Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx5e: Fix memleak in mlx5e_create_l2_table_groups

On Sun, 2020-12-27 at 10:33 +0200, Leon Romanovsky wrote:
> On Mon, Dec 21, 2020 at 07:27:31PM +0800, Dinghao Liu wrote:
> > When mlx5_create_flow_group() fails, ft->g should be
> > freed just like when kvzalloc() fails. The caller of
> > mlx5e_create_l2_table_groups() does not catch this
> > issue on failure, which leads to memleak.
> > 
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> Fixes: 33cfaaa8f36f ("net/mlx5e: Split the main flow steering table")
> 
Added

> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>

Applied to net-mlx5
Thanks