netdev - Re: [PATCH] drivers: wireless: rtlwifi: rtl8192ce: Fix construction of word rtl8192ce/trx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jan 2021 21:34:08 +1100
From:   Julian Calaby <julian.calaby@...il.com>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>
Cc:     Ping-Ke Shih <pkshih@...ltek.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Larry Finger <Larry.Finger@...inger.net>,
        baijiaju1990@...il.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers: wireless: rtlwifi: rtl8192ce: Fix construction
 of word rtl8192ce/trx.c

Hi Bhaskar,

On Tue, Jan 5, 2021 at 9:32 PM Bhaskar Chowdhury <unixbhaskar@...il.com> wrote:
>
> s/defautly/de-faulty/p
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
> index 4165175cf5c0..d53397e7eb2e 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/trx.c
> @@ -671,7 +671,7 @@ bool rtl92ce_is_tx_desc_closed(struct ieee80211_hw *hw,
>         u8 own = (u8)rtl92ce_get_desc(hw, entry, true, HW_DESC_OWN);
>
>         /*beacon packet will only use the first
> -        *descriptor defautly,and the own may not
> +        *descriptor de-faulty,and the own may not

Same comments here as the previous patch:

"de-faultly" makes less sense than "defaultly". This comment needs to
be re-written by someone who knows what's going on here.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/