netdev - Re: [PATCH net v2] docs: net: fix documentation on .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210105115149.f64yqrup6rxte4dh@skbuf>
Date:   Tue, 5 Jan 2021 13:51:49 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] docs: net: fix documentation on .ndo_get_stats

On Mon, Jan 04, 2021 at 05:22:24PM -0800, Jakub Kicinski wrote:
> Fix calling context.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  Documentation/networking/netdevices.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/networking/netdevices.rst b/Documentation/networking/netdevices.rst
> index 5a85fcc80c76..e65665c5ab50 100644
> --- a/Documentation/networking/netdevices.rst
> +++ b/Documentation/networking/netdevices.rst
> @@ -64,8 +64,8 @@ struct net_device synchronization rules
>  	Context: process
>  
>  ndo_get_stats:
> -	Synchronization: dev_base_lock rwlock.
> -	Context: nominally process, but don't sleep inside an rwlock
> +	Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
> +	Context: atomic (can't sleep under rwlock or RCU)
>  
>  ndo_start_xmit:
>  	Synchronization: __netif_tx_lock spinlock.
> -- 
> 2.26.2
> 

Reviewed-by: Vladimir Oltean <olteanv@...il.com>