netdev - Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20210105.160018.901800594374682376.davem@davemloft.net>
Date:   Tue, 05 Jan 2021 16:00:18 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     fthain@...egraphics.com.au
Cc:     kuba@...nel.org, christophe.jaillet@...adoo.fr,
        tsbogend@...ha.franken.de, chris@...kel.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 net RESEND] net/sonic: Fix some resource leaks in
 error handling paths

From: Finn Thain <fthain@...egraphics.com.au>
Date: Sun, 03 Jan 2021 11:26:26 +1100

> From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors().
> 
> This is correctly freed in the remove function, but not in the error
> handling path of the probe function. Fix this by adding the missing
> dma_free_coherent() call.
> 
> While at it, rename a label in order to be slightly more informative.
> 
> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Cc: Chris Zankel <chris@...kel.net>
> References: commit 10e3cc180e64 ("net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'")
> Fixes: 74f2a5f0ef64 ("xtensa: Add support for the Sonic Ethernet device for the XT2000 board.")
> Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Applied and queued up for -stable, thanks.