netdev - Re: [PATCH] drivers: net: wireless: realtek: Fix the word association defautly de-faulty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/W4r1rmMCnKQAQZ@Gentoo>
Date:   Wed, 6 Jan 2021 18:48:39 +0530
From:   Bhaskar Chowdhury <unixbhaskar@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     pkshih@...ltek.com, kvalo@...eaurora.org, davem@...emloft.net,
        kuba@...nel.org, Larry.Finger@...inger.net, zhengbin13@...wei.com,
        baijiaju1990@...il.com, christophe.jaillet@...adoo.fr,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: realtek: Fix the word
 association defautly de-faulty

On 09:02 Tue 05 Jan 2021, Randy Dunlap wrote:
>On 1/5/21 2:17 AM, Bhaskar Chowdhury wrote:
>> s/defautly/de-faulty/p
>>
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
>> ---
>>  drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> index c948dafa0c80..7d02d8abb4eb 100644
>> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/trx.c
>> @@ -814,7 +814,7 @@ bool rtl88ee_is_tx_desc_closed(struct ieee80211_hw *hw, u8 hw_queue, u16 index)
>>  	u8 own = (u8)rtl88ee_get_desc(hw, entry, true, HW_DESC_OWN);
>>
>>  	/*beacon packet will only use the first
>> -	 *descriptor defautly,and the own may not
>> +	 *descriptor de-faulty,and the own may not
>>  	 *be cleared by the hardware
>>  	 */
>>  	if (own)
>> --
>
>Yes, I agree with "by default". I don't know what "the own"
>means.
>
>Also, there should be a space after each beginning "*.
>
>I saw another patch where the comment block began with /**,
>which should mean "begin kernel-doc comment block", but it's
>not kernel-doc, so that /** should be changed to just "/*".
>
>
Good point Randy, there were several driver file witch have "defautly" in it
and I tried to correct that.Only that spell made it a "de-faulty" as dic
suggested . But I think it should be "by default" as you said.

The comment beginning part , let me hunt down that and fix it as you mentioned
the way it should be.

Thanks Randy.
>--
>~Randy
>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)