netdev - Re: [PATCH] net: ethernet: Fix memleak in ethoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210106084430.291a90cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 6 Jan 2021 08:44:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     dinghao.liu@....edu.cn
Cc:     "Konstantin Ryabitsev" <konstantin@...uxfoundation.org>,
        "Florian Fainelli" <f.fainelli@...il.com>,
        "Andrew Lunn" <andrew@...n.ch>, kjlu@....edu,
        "David S. Miller" <davem@...emloft.net>,
        "Jesse Brandeburg" <jesse.brandeburg@...el.com>,
        "Arnd Bergmann" <arnd@...db.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: Fix memleak in ethoc_probe

On Wed, 6 Jan 2021 18:56:23 +0800 (GMT+08:00) dinghao.liu@....edu.cn
wrote:
> > I used this one for a test:
> > 
> > https://patchwork.kernel.org/project/netdevbpf/patch/1609312994-121032-1-git-send-email-abaci-bugfix@linux.alibaba.com/
> > 
> > I'm not getting the Fixes tag when I download the mbox.  
> 
> It seems that automatically generating Fixes tags is a hard work.
> Both patches and bugs could be complex. Sometimes even human cannot
> determine which commit introduced a target bug.
> 
> Is this an already implemented functionality?

I'm not sure I understand. Indeed finding the right commit to use in 
a Fixes tag is not always easy, and definitely not easy to automate.
Human validation is always required.

If we could easily automate finding the commit which introduced a
problem we wouldn't need to add the explicit tag, backporters could
just run such script locally.. That's why it's best if the author 
does the digging and provides the right tag.

The conversation with Konstantin and Florian was about automatically
picking up Fixes tags from the mailing list by the patchwork software,
when such tags are posted in reply to the original posting, just like
review tags. But the tags are still generated by humans.