netdev - Re: [PATCH net-next 1/3] dt-bindings: net: convert Broadcom Starfighter 2 binding to the json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f4c93fe-4d51-c76a-c671-39d8eaad0e01@gmail.com>
Date:   Wed, 6 Jan 2021 11:36:37 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: convert Broadcom
 Starfighter 2 binding to the json-schema

On 1/6/21 4:07 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> This helps validating DTS files. Only the current (not deprecated one)
> binding was converted.
> 
> Minor changes:
> 1. Dropped dsa/dsa.txt references
> 2. Updated node name to match dsa.yaml requirement
> 3. Fixed 2 typos in examples
> 
> The new binding was validated using the dt_binding_check.
> 
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---

This looks good to me, but we would want Rob to review this binding
obviously. Just one comment below.

[snip]

> +
> +  reset-names:
> +    const: switch
> +
> +  clocks:
> +    items:
> +      - description: switch's main clock (valid for both BCM7445 and BCM7278)
> +      - description: only applicable to BCM7445 and is to support dividing the switch core clock.

Since this is a YAML binding we could adjust the number of min/max clock
items here based on the compatible string.
-- 
Florian