netdev - Re: [PATCH next] net: dsa: print error on invalid port index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <X/Y6o5SJBAeyBPHx@lunn.ch>
Date:   Wed, 6 Jan 2021 23:33:07 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Rafał Miłecki <zajec5@...il.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH next] net: dsa: print error on invalid port index

On Wed, Jan 06, 2021 at 10:09:15AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Looking for an -EINVAL all over the dsa code could take hours for
> inexperienced DSA users.

Following this argument, you should add dev_err() by every -EINVAL.

> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew