netdev - Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210106151842.74edc6cd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 6 Jan 2021 15:18:42 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     wangyingjie55@....com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] af/rvu_cgx: Fix missing check bugs in rvu_cgx.c

On Tue,  5 Jan 2021 22:49:17 -0800 wangyingjie55@....com wrote:
> From: Yingjie Wang <wangyingjie55@....com>
> 
> In rvu_mbox_handler_cgx_mac_addr_get()
> and rvu_mbox_handler_cgx_mac_addr_set(),
> the msg is expected only from PFs that are mapped to CGX LMACs.
> It should be checked before mapping,
> so we add the is_cgx_config_permitted() in the functions.
> 
> Fixes: 85482bb ("af/rvu_cgx: Fix missing check bugs in rvu_cgx.c")
> Signed-off-by: Yingjie Wang <wangyingjie55@....com>

Thanks for the tag but:

Fixes tag: Fixes: 85482bb ("af/rvu_cgx: Fix missing check bugs in rvu_cgx.c")
Has these problem(s):
	- Target SHA1 does not exist

This hash does not seem to exist in any tree known to linux-next.

The hash should also be at least 12 chars.