netdev - Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210107092106.012e6721@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 7 Jan 2021 09:21:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Rafał Miłecki <zajec5@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Doug Berger <opendmb@...il.com>,
        Ray Jui <ray.jui@...adcom.com>,
        Arun Parameswaran <arun.parameswaran@...adcom.com>,
        Murali Krishna Policharla <murali.policharla@...adcom.com>,
        Timur Tabi <timur@...nel.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Vladimir Oltean <vladimir.oltean@....com>,
        netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH net-next 2/2] net: broadcom: share header defining
 UniMAC registers

On Thu, 7 Jan 2021 09:14:17 -0800 Florian Fainelli wrote:
> > I can reproduce that after switching from mips to arm64. Before this
> > change bgmac.h was not using BIT() macro. Now it does and that macro
> > forces UL (unsigned long).
> > 
> > Is there any cleaner solution than below one?  
> 
> Don't use BIT(), if the constants are 32-bit unsigned integer, maybe
> open coding them as (1 << x) is acceptable for that purpose.

No objections from my side, I think we already have a number of drivers
open coding the shifts for that very reason already.