netdev - Re: [net-next 15/19] can: tcan4x5x: rework SPI access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60cc440e-a292-0b59-16d7-79f4e25c13ee@pengutronix.de>
Date:   Thu, 7 Jan 2021 22:19:40 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        linux-can@...r.kernel.org, kernel@...gutronix.de,
        Dan Murphy <dmurphy@...com>, Sean Nyekjaer <sean@...nix.com>
Subject: Re: [net-next 15/19] can: tcan4x5x: rework SPI access

On 1/7/21 8:00 PM, Jakub Kicinski wrote:
> On Thu,  7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote:
>> +struct __packed tcan4x5x_map_buf {
>> +	struct tcan4x5x_buf_cmd cmd;
>> +	u8 data[256 * sizeof(u32)];
>> +} ____cacheline_aligned;
> 
> Interesting attribute combo, I must say.

__packed as it's the byte stream send to the chip via SPI.

____cacheline_aligned, as it might be subject to DMA mapping in the SPI host
driver. An alternative would be to allocate these with separate kmalloc().

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)