netdev - Re: [PATCH net-next] net: phy: replace mutex_is_locked with lockdep_assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210107145533.17ea01bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 7 Jan 2021 14:55:33 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: replace mutex_is_locked with
 lockdep_assert_held in phylib

On Thu, 7 Jan 2021 22:15:06 +0100 Andrew Lunn wrote:
> On Wed, Jan 06, 2021 at 02:03:40PM +0100, Heiner Kallweit wrote:
> > Switch to lockdep_assert_held(_once), similar to what is being done
> > in other subsystems. One advantage is that there's zero runtime
> > overhead if lockdep support isn't enabled.
> > 
> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>  
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks!

If I was willing to let my pedantic flag fly I'd ask for the lockdep
header to be included explicitly, but I guess in practice the chances
of it not being pulled into sources which use locking is 0.