netdev - Re: [PATCH] rxrpc: Call state should be read with READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABdVr8TTtj+sK8EuhNc6FS+mthmx5jZyDAnqh9AMa68=rEywoQ@mail.gmail.com>
Date:   Fri, 8 Jan 2021 10:23:41 +1100
From:   Baptiste Lepers <baptiste.lepers@...il.com>
To:     David Howells <dhowells@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-afs@...ts.infradead.org,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] rxrpc: Call state should be read with READ_ONCE() under
 some circumstances

Yes, that's fine with me. Thanks for the clarification of the commit message.
(Sorry for the double send, I forgot to enable plain text on my
previous answer.)

Baptiste.

On Thu, Jan 7, 2021 at 10:05 PM David Howells <dhowells@...hat.com> wrote:
>
> Baptiste Lepers <baptiste.lepers@...il.com> wrote:
>
> > The call state may be changed at any time by the data-ready routine in
> > response to received packets, so if the call state is to be read and acted
> > upon several times in a function, READ_ONCE() must be used unless the call
> > state lock is held.
>
> I'm going to add:
>
>     As it happens, we used READ_ONCE() to read the state a few lines above the
>     unmarked read in rxrpc_input_data(), so use that value rather than
>     re-reading it.
>
> to the commit message, if that's okay by you.
>
> David
>