netdev - Re: [PATCH iproute2] build: Fix link errors on some systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d5f2f49-83cb-8f54-cc01-678282c16074@nvidia.com>
Date:   Thu, 7 Jan 2021 08:52:08 +0200
From:   Roi Dayan <roid@...dia.com>
To:     Petr Machata <petrm@...dia.com>
CC:     <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        Petr Machata <me@...chata.org>
Subject: Re: [PATCH iproute2] build: Fix link errors on some systems



On 2021-01-06 4:24 PM, Petr Machata wrote:
> 
> Roi Dayan <roid@...dia.com> writes:
> 
>> On 2021-01-06 3:16 PM, Petr Machata wrote:
>>> Regarding the publishing, the _jw reference can be changed to a call to
>>> is_json_context(), which does the same thing. Then _jw can stay private
>>> in json_print.c.
>>> Exposing an _IS_JSON_CONTEXT / _IS_FP_CONTEXT might be odd on account of
>>> the initial underscore, but since it's only used in implementations,
>>> maybe it's OK?
>>>
>>
>> With is_json_context() I cannot check the type passed by the caller.
>> i.e. PRINT_JSON, PRINT_FP, PRINT_ANY.
> 
> I meant s/_jw/is_json_context()/. Like this:
> 
> #define _IS_JSON_CONTEXT(type) \
>      ((type & PRINT_JSON || type & PRINT_ANY) && is_json_context())
> 
> Then _jw can stay private.
> 

right. thanks. i'll submit v2 for review.