netdev - Re: [PATCH net-next 1/2] ravb: remove APSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXqUXH1_0j5H6dPL=jnUVi8zwqHk-zpOpGQcT7x8_dUJw@mail.gmail.com>
Date:   Thu, 7 Jan 2021 10:37:16 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sergey Shtylyov <s.shtylyov@...russia.ru>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] ravb: remove APSR_DM

On Wed, Jan 6, 2021 at 9:43 PM Sergey Shtylyov <s.shtylyov@...russia.ru> wrote:
> According to the R-Car Series, 3rd Generation User's Manual: Hardware,
> Rev. 1.50, there's no APSR.DM field, instead therea are 2 independent

there

> RX/TX clock internal delay bits.  Follow the suit: remove #define APSR_DM
> and rename #define's APSR_DM_{R|T}DM to APSR_{R|T}DM.
>
> While at it, do several more things to the declaration of *enum* APSR_BIT:
> - remove superfluous indentation;
> - annotate APSR_MEMS as undocumented;
> - annotate APSR as R-Car Gen3 only.
>
> Fixes: 61fccb2d6274 ("ravb: Add tx and rx clock internal delays mode of APSR")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@...russia.ru>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds