netdev - Re: [net-next PATCH v13 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210108150214.3f821204@kernel.org>
Date:   Fri, 8 Jan 2021 15:02:14 +0100
From:   Marek Behún <kabel@...nel.org>
To:     Pavana Sharma <pavana.sharma@...i.com>
Cc:     andrew@...n.ch, ashkan.boldaji@...i.com, davem@...emloft.net,
        f.fainelli@...il.com, kuba@...nel.org, lkp@...el.com,
        netdev@...r.kernel.org, vivien.didelot@...il.com
Subject: Re: [net-next PATCH v13 4/4] net: dsa: mv88e6xxx: Add support for
 mv88e6393x family of Marvell

On Fri,  8 Jan 2021 19:50:56 +1000
Pavana Sharma <pavana.sharma@...i.com> wrote:

> +int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane,
> +		    bool on)
> +{
> +	u8 cmode;
> +
> +	if (port != 0 && port != 9 && port != 10)
> +		return -EOPNOTSUPP;
> +
> +	cmode = chip->ports[port].cmode;
> +
> +	mv88e6393x_serdes_port_config(chip, lane, on);
> +
> +	switch (cmode) {
> +	case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
> +	case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
> +		return mv88e6390_serdes_power_sgmii(chip, lane, on);
> +	case MV88E6XXX_PORT_STS_CMODE_10GBASER:
> +		return mv88e6390_serdes_power_10g(chip, lane, on);

Shoudln't mv88e6390_serdes_power_10g() be called even for 5GBASER ?
Have you tested 5GBASER at all?

Marek