netdev - Re: Flaw in "random32: update the net random state on interrupt and activity"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+GF1KuWLwKWxxafWrfQMfFMJdtS2rb=SzgAn9pERKg0g@mail.gmail.com>
Date:   Fri, 8 Jan 2021 16:41:43 +0100
From:   Eric Dumazet <edumazet@...gle.com>
To:     Sedat Dilek <sedat.dilek@...il.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: Flaw in "random32: update the net random state on interrupt and activity"

On Fri, Jan 8, 2021 at 2:51 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
>
> On Fri, Jan 8, 2021 at 2:08 PM Sedat Dilek <sedat.dilek@...il.com> wrote:
> >
> > On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > > > Also, I tried the diff for tcp_conn_request...
> > > > With removing the call to prandom_u32() not useful for
> > > > prandom_u32/tracing via perf.
> > >
> > > I am planning to send the TCP patch once net-next is open. (probably next week)
> >
> > Ping.
> >
> > What is the status of this?
> >
>
> I am attaching the updated diff against latest Linus Git.
>
> - Sedat -

I have decided to not pursue this.

skb->hash might be populated by non random data if fed from a
problematic source/driver.

Better to leave current code in place, there is no convincing argument
to change this.