netdev - Re: [PATCH iproute2 v2 1/1] build: Fix link errors on some systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210108081806.2219efda@hermes.local>
Date:   Fri, 8 Jan 2021 08:18:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Petr Machata <petrm@...dia.com>
Cc:     Roi Dayan <roid@...dia.com>, <netdev@...r.kernel.org>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2 v2 1/1] build: Fix link errors on some systems

On Fri, 8 Jan 2021 14:08:57 +0100
Petr Machata <petrm@...dia.com> wrote:

> Stephen Hemminger <stephen@...workplumber.org> writes:
> 
> > On Thu,  7 Jan 2021 09:13:34 +0200
> > Roi Dayan <roid@...dia.com> wrote:
> >  
> >> +#define _IS_JSON_CONTEXT(type) ((type & PRINT_JSON || type & PRINT_ANY) && is_json_context())
> >> +#define _IS_FP_CONTEXT(type) (!is_json_context() && (type & PRINT_FP || type & PRINT_ANY))  
> >
> > You could fold the comparisons? and why are the two options doing comparison in different order?
> >
> > #define _IS_JSON_CONTEXT(type) (is_json_context() && (type & (PRINT_JSON | PRINT_ANY))
> > #define _IS_FP_CONTEXT(type)   (!is_json_context() && (type & (PRINT_FP || PRINT_ANY))  
> 
> (s/||/|/)

Agree.
This was just an email edit, never tried